Open
Conversation
sjaeckel
force-pushed
the
more-fixes-and-improvements
branch
from
6cde560 to
1ee37a5
Compare
Member
|
Do we actually still need sha1_x86_init and sha1_c_init when they are both equal to sha1_init? |
Member
Author
Nope, they could be defined to |
Member
|
similarly sha224_x86_init / sha256_x86_init vs sha224_c_init / sha256_c_init |
They're the only ones which don't follow the same pattern. Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
sjaeckel
force-pushed
the
more-fixes-and-improvements
branch
from
1ee37a5 to
2e881d6
Compare
Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
* Use a shared init function. * Fix some functions used in descriptors and implementation. Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
sjaeckel
force-pushed
the
more-fixes-and-improvements
branch
from
2e881d6 to
bb93c6e
Compare
MarekKnapek
reviewed
May 7, 2026
| { | ||
| ulong32 *state = LTC_ALIGN_BUF(md->sha256.state_buf, 16); | ||
| if (state != md->sha256.state) { | ||
| XMEMMOVE(state, md->sha256.state, 8 * sizeof(ulong32)); |
Contributor
There was a problem hiding this comment.
I'm not sure this is safe. What if the user memcpy the state to a new place. Then they destroys the old state. Think of free(). Then they call process or finish function. The memmove would access already freed memory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Fixes:tag to the commit message