feat(lxl-web): Remove redundant search params (LWS-405)#1352
Open
johanbissemattsson wants to merge 4 commits intodevelopfrom
Open
feat(lxl-web): Remove redundant search params (LWS-405)#1352johanbissemattsson wants to merge 4 commits intodevelopfrom
johanbissemattsson wants to merge 4 commits intodevelopfrom
Conversation
| // Always reset these params on new search | ||
| p.set('_offset', '0'); | ||
| p.delete('_offset'); | ||
| p.delete('_limit'); |
Contributor
There was a problem hiding this comment.
Dunno if being able to manually change search items per page (using _limit), is a useful hidden feature? That will maybe become a ui feature someday. This prevents that.
I don't have a strong opinion myself...
Contributor
There was a problem hiding this comment.
But hmm, pagination links keeps any existing _limit, but facet links throws it away. Wonder if the latter is a bug? @kwahlin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tickets involved
LWS-405
Solves
Removes redundant search params as
_limit,_offset,_sortand_spelldoesn't seem to be required any longer (the links in the filter panel omits them).Summary of changes
_limitsearch param on new searches (these would otherwise be kept after using the pagination)