Skip to content

Feature/port264specs #1729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
klngwll merged 2 commits into from
Mar 23, 2026
Merged

Feature/port264specs #1729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
efa9215
Port PR1064 008 specs
klngwll Mar 23, 2026
fe24482
Add more 264 coverage with named tests
klngwll Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions whelk-core/src/main/resources/ext/marcframe-bib-postprocessing.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,24 @@
},
"back": "both"
},
{
"name": "Metatesting postprocess merge",
"source": {
"marc:primaryProvisionActivity": {
"@type": "PrimaryProvisionActivity",
"marc:publicationStatus": "marc:SingleKnownDateProbableDate",
"year": "2021",
"country": [ {"@id": "https://id.kb.se/country/sw"} ]
},
"publication": [ {"@type": "Publication", "year": "2021" } ]
},
"result": {
"publication": [
{"@type": "PrimaryPublication", "country": [ {"@id": "https://id.kb.se/country/sw"} ], "year": "2021"}
]
},
"back": "both"
},
{
"name": "also handle non-array publication object",
"source": {
Expand Down
236 changes: 236 additions & 0 deletions whelk-core/src/main/resources/ext/marcframe.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2761,6 +2761,122 @@
}
}
},
{
"name": "With publication place, agent and date (264 $a $b $c) and 008",
"source": [
{"008": "| s2020 sw |||||||||||000 || | "},
{"264": {"ind1": " ", "ind2": "1", "subfields": [
{"a": "Stockholm :"},
{"b": "Norstedts,"},
{"c": "2020"}
]}}
],
"result": {
"mainEntity": {
"marc:primaryProvisionActivity": {
"@type": "PrimaryProvisionActivity",
"country": [
{"@id": "https://id.kb.se/country/sw"}
],
"marc:publicationStatus": "marc:SingleKnownDateProbableDate",
"year": "2020"
},
"publication": [
{
"@type": "Publication",
"agent": {"@type": "Agent", "label": "Norstedts"},
"place": {"@type": "Place", "label": "Stockholm"},
"year": "2020"
}
]
}
}
},
{
"name": "No publication place (264 $a) and 008",
"source": [
{"008": "| s2021 sw |||||||||||000 || | "},
{"264": {"ind1": " ", "ind2": "1", "subfields": [
{"b": "Bonnier,"},
{"c": "2021"}
]}}
],
"result": {
"mainEntity": {
"marc:primaryProvisionActivity": {
"@type": "PrimaryProvisionActivity",
"country": [
{"@id": "https://id.kb.se/country/sw"}
],
"marc:publicationStatus": "marc:SingleKnownDateProbableDate",
"year": "2021"
},
"publication": [
{
"@type": "Publication",
"agent": {"@type": "Agent", "label": "Bonnier"},
"year": "2021"
}
]
}
}
},
{
"name": "Publisher only (264 $b) with unknown date/country in 008",
"source": [
{"008": "| snnnn xx |||||||||||000 || | "},
{"264": {"ind1": " ", "ind2": "1", "subfields": [
{"b": "Saga Egmont"}
]}}
],
"result": {
"mainEntity": {
"marc:primaryProvisionActivity": {
"@type": "PrimaryProvisionActivity",
"country": [
{"@id": "https://id.kb.se/country/xx"}
],
"marc:publicationStatus": "marc:SingleKnownDateProbableDate",
"year": "nnnn"
},
"publication": [
{
"@type": "Publication",
"agent": {"@type": "Agent", "label": "Saga Egmont"}
}
]
}
}
},
{
"name": "Conflicting 008 year and 264$c year are both preserved",
"source": [
{"008": "| s2020 sw |||||||||||000 || | "},
{"264": {"ind1": " ", "ind2": "1", "subfields": [
{"b": "Norstedts,"},
{"c": "2019"}
]}}
],
"result": {
"mainEntity": {
"marc:primaryProvisionActivity": {
"@type": "PrimaryProvisionActivity",
"country": [
{"@id": "https://id.kb.se/country/sw"}
],
"marc:publicationStatus": "marc:SingleKnownDateProbableDate",
"year": "2020"
},
"publication": [
{
"@type": "Publication",
"agent": {"@type": "Agent", "label": "Norstedts"},
"year": "2019"
}
]
}
}
},
{
"name": "export fixedDefault in the absence of frequency in series",
"source": {
Expand Down Expand Up @@ -9313,6 +9429,7 @@
"subfieldOrder": "6 3 ...",
"_spec": [
{
"name": "publication and manufacture split from i2=1 and i2=3",
"source": [
{"264": {"ind1": " ", "ind2": "1", "subfields": [
{"a": "Stockholm :"}, {"b": "Bonnier,"}, {"c": "1996"}
Expand All @@ -9339,6 +9456,125 @@
}}
},
{
"name": "publication place only from i2=1 $a",
"source": [
{"264": {"ind1": " ", "ind2": "1", "subfields": [
{"a": "Lund"}
]}}
],
"result": {"mainEntity": {
"publication": [
{
"@type": "Publication",
"place": {"@type": "Place", "label": "Lund"}
}
]
}}
},
{
"name": "publication agent only from i2=1 $b",
"source": [
{"264": {"ind1": " ", "ind2": "1", "subfields": [
{"b": "Bonnier"}
]}}
],
"result": {"mainEntity": {
"publication": [
{
"@type": "Publication",
"agent": {"@type": "Agent", "label": "Bonnier"}
}
]
}}
},
{
"name": "publication malformed date token from i2=1 $c",
"source": [
{"264": {"ind1": " ", "ind2": "1", "subfields": [
{"c": "circa 199x?"}
]}}
],
"result": {"mainEntity": {
"publication": [
{
"@type": "Publication",
"date": "circa 199x?"
}
]
}}
},
{
"name": "production from i2=0",
"source": [
{"264": {"ind1": " ", "ind2": "0", "subfields": [
{"a": "Malmö :"}, {"b": "Malmö stad,"}, {"c": "2022"}
]}}
],
"result": {"mainEntity": {
"production": [
{
"@type": "Production",
"place": {"@type": "Place", "label": "Malmö"},
"agent": {"@type": "Agent", "label": "Malmö stad"},
"year": "2022"
}
]
}}
},
{
"name": "distribution from i2=2",
"source": [
{"264": {"ind1": " ", "ind2": "2", "subfields": [
{"a": "Göteborg :"}, {"b": "Disa Distribution,"}, {"c": "2019"}
]}}
],
"result": {"mainEntity": {
"distribution": [
{
"@type": "Distribution",
"place": {"@type": "Place", "label": "Göteborg"},
"agent": {"@type": "Agent", "label": "Disa Distribution"},
"year": "2019"
}
]
}}
},
{
"name": "manufacture appliesTo from $3",
"source": [
{"264": {"ind1": " ", "ind2": "3", "subfields": [
{"3": "Originalboxen:"}, {"a": "Uppsala :"}, {"b": "Tryckhuset"}
]}}
],
"result": {"mainEntity": {
"manufacture": [
{
"@type": "Manufacture",
"appliesTo": {"@type": "Resource", "label": "Originalboxen"},
"place": {"@type": "Place", "label": "Uppsala"},
"agent": {"@type": "Agent", "label": "Tryckhuset"}
}
]
}}
},
{
"name": "copyright from i2=4 $c",
"source": [
{"264": {"ind1": " ", "ind2": "4", "subfields": [
{"c": "©2012"}
]}}
],
"result": {"mainEntity": {
"copyright": [
{
"@type": "Copyright",
"date": "©2012"
}
]
}}
},
{
"name": "publication multi-part with copyright from i2=4",
"source": [
{"264": {"ind1": " ", "ind2": "1", "subfields": [
{"a": "Stockholm"}, {"b": "Bonnier"}, {"c": "1996"},
Expand Down
Loading