Extract more specific datatypes#69
Merged
brycekbargar merged 5 commits intolibrary-data-platform:release-v4.0.0from Mar 10, 2026
Merged
Extract more specific datatypes#69brycekbargar merged 5 commits intolibrary-data-platform:release-v4.0.0from
brycekbargar merged 5 commits intolibrary-data-platform:release-v4.0.0from
Conversation
brycekbargar
merged commit 96f1ce6
into
library-data-platform:release-v4.0.0
5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another huge benefit of the transformation refactor is that we can more easily reason about how the transformation is happening and how datatype conversion happens. This converts columns that have been text into datetimes. It also gets makes the numeric types more specific. As a nice side result of these changes the size of these tables should go down significantly and also they'll be faster even without indexes.
I don't love the pytz is a requirement in order for duckdb to have the timestamptz type. Hopefully they fix this upstream at some point.