Switch LDLite to using the new server side transform#66
Merged
brycekbargar merged 12 commits intolibrary-data-platform:release-v4.0.0from Mar 4, 2026
Conversation
493b5fc
into
library-data-platform:release-v4.0.0
5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This switches LDLite to using the new transform. The legacy transform is still available by using a parameter passed to the query method. After making the switch and testing with both the unit tests and against Five Colleges production instance a number of regressions were found and fixed. While testing against the production instance the load_history table proved to be a thorn in my side and the v1 was added in lieu of actually using a migration framework for it.
Indexing for the new transformation will be implemented in the next PR. In testing, this implementation runs out of memory for large tables with large objects. I've experimented with fixes and there will be a follow up performance PR to address this issue.