chore: fix gossipsub benchmarks#3511
Open
dozyio wants to merge 8 commits into
Open
Conversation
Collaborator
Author
|
Might want to migrate off benchmark.js as it hasn't been updates in a long while |
Member
|
i think tinybench is new standard https://github.com/tinylibs/tinybench |
Collaborator
Author
|
Thinking to get this one in as it matches the rest of the repo and then migrate all off benchmark.js |
Extract the per-file runBenchmark helper (identical except protobuf's runsFactor, now defaulted to 1) into test/utils/benchmark.ts.
Replace the @ts-expect-error on the benchmark import with the real types (Benchmark.Deferred, Benchmark) in the shared benchmark helper.
Use aegir's bundled mocha (no direct mocha dep) and forward --exit so the run terminates after benchmarks leave handles open.
Times heartbeat() instead of the publish fan-out (now a one-time warm-up), and stops the nodes so their timers don't keep the run alive.
Member
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix gossipsub benchmarks so that they can run
Change checklist