add support for sending error codes on stream reset#122
Merged
sukunrt merged 2 commits intosukun/conn-error-2from Sep 12, 2024
Merged
add support for sending error codes on stream reset#122sukunrt merged 2 commits intosukun/conn-error-2from
sukunrt merged 2 commits intosukun/conn-error-2from
Conversation
sukunrt
force-pushed
the
sukun/stream-error-code
branch
from
945e586 to
33d9f38
Compare
sukunrt
force-pushed
the
sukun/stream-error-code
branch
from
33d9f38 to
f56b1c3
Compare
sukunrt
force-pushed
the
sukun/stream-error-code
branch
from
e17eaa8 to
c17399c
Compare
sukunrt
force-pushed
the
sukun/stream-error-code
branch
from
c17399c to
9190b78
Compare
Member
Author
|
Merged into #121 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements libp2p/specs#622
We use the Length field of a Window Update frame to send an error code on stream reset. This is safe since the window has no meaning post a reset, so existing implementations won't be impacted.
We cannot send the error in the Data frame as the body there's subject to flow control.