fix(routing): add per-peer timeouts for PutValue and Provide#1222
Merged
guillaumemichel merged 1 commit intomasterfrom Jan 21, 2026
Merged
fix(routing): add per-peer timeouts for PutValue and Provide#1222guillaumemichel merged 1 commit intomasterfrom
guillaumemichel merged 1 commit intomasterfrom
Conversation
when communicating with unresponsive peers, PutValue and classicProvide could hang indefinitely because they used context.WithCancel or reused the parent context without a per-operation timeout. this adds a 30-second per-peer timeout to prevent a single slow peer from blocking the entire operation. the timeout matches what updatePeerValues already used, now extracted into a shared constant. similar issue was fixed in go-libp2p#3448 where stream.Close could hang indefinitely on unresponsive peers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when communicating with unresponsive peers,
PutValueandclassicProvidecould (a) hang indefinitely because they usedcontext.WithCancelwithout timeout or (b) reused the "global" parent context without a per-operation timeout.this PR adds a 30-second per-peer timeout to prevent a single slow peer from blocking the entire operation. the timeout matches what
updatePeerValuesalready used, now extracted into a shared constant.this is another "belt and suspenders" protection, inspired by issue was fixed in libp2p/go-libp2p#3448 where
stream.Closecould hang indefinitely on unresponsive peers