Improve error resilience by collecting errors and returning them all#30
Open
andsens wants to merge 2 commits intolibdns:mainfrom
Open
Improve error resilience by collecting errors and returning them all#30andsens wants to merge 2 commits intolibdns:mainfrom
andsens wants to merge 2 commits intolibdns:mainfrom
Conversation
andsens
force-pushed
the
ft-error-resilience
branch
from
710e7a7 to
b7cb260
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #29.
This change modifies all API functions to collect errors while performing individual API calls and then returning those errors when the changeset is done. I've taken care not to return any records that encountered errors.
This doesn't fundamentally change how the API behaves outwardly, since whether the some calls fail early all depends on the ordering of the records.
It does however make it so that even when errors are returned, the caller can see which records were successfully changed (previously
nilwas just returned, instead ofresults).