Skip to content

Lower minimum TTL to 600s #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MasterEvarior merged 2 commits into from
Nov 14, 2024
Merged

Lower minimum TTL to 600s #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f91cdcd
Lower minimum TTL to 600s
fabiante Nov 13, 2024
7790e57
Update TTL documentation in README.md
fabiante Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ Because the Hosttech API does not provide a way to manipulate a generic "Type,Na
Any unsupported record types returns an error.

### Minimal TTL
The Time-to-Life has to be at least 600 seconds, anything below that will be rejected by the API
The Time-to-Life has to be at least 600 seconds. If you try to set a lower value, the client will
automatically set it to 600 seconds. Smaller values would be rejected by the Hosttech API.

## Further documentation
Any further documentation that could be helpful:
Expand Down
6 changes: 3 additions & 3 deletions models.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,9 +232,9 @@ func (t TLSARecord) fromLibdnsRecord(record libdns.Record) HosttechRecord {

func durationToIntSeconds(duration time.Duration) int {
durationInSeconds := duration.Seconds()
//The minimum amount is 10800 seconds
if durationInSeconds < 10800 {
return 10800
// The minimum amount is 600 seconds
if durationInSeconds < 600 {
return 600
}
return int(durationInSeconds)
}
Expand Down