Fixed memory leak in threadpool #1188
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transitioning from raw pointers (
std::thread*) tostd::shared_ptr<std::thread>to fix memory leak (there seems to be nothing thatdeletethe raw ptr after the thread is terminated).std::threadobjects now are wrapped instd::shared_ptr(so the memory is now automatically managed)CreateThreadnow creates thread usingstd::make_sharedAddThreadhas been modified to acceptstd::shared_ptr<std::thread>instead of raw pointers