-
-
Notifications
You must be signed in to change notification settings - Fork 39
Add option to copy all sectors without requiring span #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Rips all sectors without specifying a span argument.
|
Looks good to me. Thanks! I'll leave this open for a few days in case any others care to comment. If no further comments, I will merge this before the end of the week. |
|
The description in usage does not seem correct to me, if a span is specified this would disable the span. The usage advice does not say that. |
@eshattow: |
|
I've pushed a minor cosmetic change to make the previous commit a bit more readable. Let me know if any/all of the commits should be squashed or left separate. |
eshattow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any additional objection I have is overly complex to implement, i.e. introducing a special span token instead of a dedicated commandline flag argument. I think in some situations "copy all sectors" is not a correct description when the span is all sectors yet nothing is copied. If I was a user wanting to copy all sectors then that language makes it sure easier to find what I want to do exactly. LGTM this is easy to understand and readable.
Thanks for the review and sharing your detailed thoughts. Feel free to note this as an issue (or better fix in a PR). You could also note this as a Discussion item if you want. |
Addresses #58 by setting up an option to copy the entire disc.
Presumably,
cdda_disc_firstsectorandcdda_disc_lastsectorare the appropriate functions. I'm not sure if there needs to be checks accounting for the offset or whether those function names are extremely literal and aren't subject to needing offset adjusting.The name of the option and the short invocation are fully open to bikeshedding. I just tried to find names which made sense or weren't being used already.