Skip to content

Remove cast to double for rpc::value_t integer serializations. #734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evoskuil merged 1 commit into from
Mar 2, 2026
Merged

Remove cast to double for rpc::value_t integer serializations. #734

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions src/messages/rpc/model.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ BC_PUSH_WARNING(NO_CASTS_FOR_ARITHMETIC_CONVERSION)

DEFINE_JSON_FROM_TAG(value_t)
{
// In the general model, all numbers serialize to double.
// Boost serializes all numbers as double, but varies precision by type.
std::visit(overload
{
[&](null_t) NOEXCEPT
Expand All @@ -78,35 +78,35 @@ DEFINE_JSON_FROM_TAG(value_t)
},
[&](int8_t visit) THROWS
{
value = static_cast<double>(visit);
value = visit;
},
[&](int16_t visit) THROWS
{
value = static_cast<double>(visit);
value = visit;
},
[&](int32_t visit) THROWS
{
value = static_cast<double>(visit);
value = visit;
},
[&](int64_t visit) THROWS
{
value = static_cast<double>(visit);
value = visit;
},
[&](uint8_t visit) THROWS
{
value = static_cast<double>(visit);
value = visit;
},
[&](uint16_t visit) THROWS
{
value = static_cast<double>(visit);
value = visit;
},
[&](uint32_t visit) THROWS
{
value = static_cast<double>(visit);
value = visit;
},
[&](uint64_t visit) THROWS
{
value = static_cast<double>(visit);
value = visit;
},
[&](const string_t& visit) THROWS
{
Expand Down
Loading