Fix nullable bugs in Select and From #22
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the `Opt` class in `Opt.cs` to include XML documentation for the `From` method, which now supports both nullable value types and non-nullable reference types. Converted `Zip` and `Flatten` methods to extension methods. Changed the constructor of `Opt<T>` to internal and modified the `Select` method to accept functions returning nullable types. Added a new `Where` method for filtering options based on predicates. In `OptTests.cs`, added unit tests for the `Select` and `Where` methods, covering value transformations, null handling, and behavior when the option is `None`. Included additional tests for casting options to validate correct and incorrect casts.
Codecov ReportAttention: Patch coverage is
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the
Optclass inOpt.csto include XML documentation for theFrommethod, which now supports both nullable value types and non-nullable reference types. ConvertedZipandFlattenmethods to extension methods. Changed the constructor ofOpt<T>to internal and modified theSelectmethod to accept functions returning nullable types. Added a newWheremethod for filtering options based on predicates.In
OptTests.cs, added unit tests for theSelectandWheremethods, covering value transformations, null handling, and behavior when the option isNone. Included additional tests for casting options to validate correct and incorrect casts.