Config support #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamaharon
reviewed
Oct 9, 2025
Owner
There was a problem hiding this comment.
Hey, thanks for the pr!
Please keep this pr limited to only adding config support, not any other new features or flags for now. If there's something that you need to add necessary for configs, please explain in the pr description.
I wonder if we could derive Config on the existing Args, instead of needing an entirely new AppConfig, have you tried that?
Author
|
@liamaharon thanks for the feedback. Nah, I hvn't tried with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added config support (issue #3)
Now user can configure --remote-path once and avoids having to re-specify them each run.
Implemented: