Skip to content

method type fix #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
getda wants to merge 1 commit into
base: main
Choose a base branch
from
Open

method type fix #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions src/Enumable.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,19 @@ public static function getValues(): array;

public static function getDescriptions(): array;

public static function hasValue($value): bool;
public static function hasValue(mixed $value): bool;

public static function hasName(string $key): bool;
public static function hasName(string|null $key): bool;

public static function getDescriptionByName(string $name): string;
public static function getDescriptionByName(string|null $name): string;

public static function getDescriptionByValue($value): string;
public static function getDescriptionByValue(mixed $value): string;

public static function getValueByName(): string|null;

public function getDescription(): string;

public function getName();
public function getName(): string|int;

public function getValue();
public function getValue(): mixed;
}
8 changes: 4 additions & 4 deletions src/HasEnum.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public static function hasValue($value, bool $strict = false): bool
return $strict ? in_array($value, $values, $strict) : in_array((string) $value, array_map('strval', $values), true);
}

public static function hasName(string $key): bool
public static function hasName(string|null $key): bool
{
return in_array($key, static::getNames(), true);
}
Expand All @@ -36,12 +36,12 @@ public static function getDescriptionByValue($value): string
return static::isBacked() ? (static::tryFrom($value)?->getDescription() ?: '') : '';
}

public static function getDescriptionByName(string $name): string
public static function getDescriptionByName(string|null $name): string
{
return static::getDescriptions()[$name] ?? '';
}

public static function getValueByName(string $name)
public static function getValueByName(string|null $name): string|null
{
if (!static::isBacked()) {
return null;
Expand All @@ -66,7 +66,7 @@ public function getName(): string|int
return $this->name;
}

public function getValue()
public function getValue(): mixed
{
return static::getValues() ? $this->value : null;
}
Expand Down