config: add enable_native_k8s_orchestration to EdgeNodeCluster#147
config: add enable_native_k8s_orchestration to EdgeNodeCluster#147naiming-zededa wants to merge 2 commits into
Conversation
naiming-zededa
requested review from
andrewd-zededa,
cshari-zededa,
milan-zededa and
zedi-pramodh
zedi-pramodh
left a comment
zedi-pramodh
left a comment
There was a problem hiding this comment.
Basically you are saying if REPLICATED STORAGE type just do ENC only. If REPLICATED STORAGE type plus this boolean then its ENC + ZKS combined.
Only curious question is why can't we have a separate enum for this type instead of controlling through a boolean ?
|
oh I see why, basically customers can start with ENC and then enable Kubernetes workflows. |
eriknordmark
left a comment
eriknordmark
left a comment
There was a problem hiding this comment.
@naiming-zededa can you split into two commits with the second one carrying the generated files?
Add a boolean field to EdgeNodeCluster to enable native Kubernetes orchestration as an opt-in option alongside CLUSTER_TYPE_REPLICATED_STORAGE, replacing the role previously served by CLUSTER_TYPE_K3S_BASE (marked for future phase-out). Generate Go and Python bindings. Signed-off-by: naiming-zededa <naiming@zededa.com> Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…odeCluster - add generated files. Signed-off-by: naiming-zededa <naiming@zededa.com>
naiming-zededa
force-pushed
the
naiming-encc-add-kube
branch
from
e80a87f to
806f269
Compare
updated. |
yes. that is the intention for this change. |
cshari-zededa
left a comment
cshari-zededa
left a comment
There was a problem hiding this comment.
LGTM, thanks @naiming-zededa
4 participants
Add a boolean field to EdgeNodeCluster to enable native Kubernetes
orchestration as an opt-in option alongside
CLUSTER_TYPE_REPLICATED_STORAGE, replacing the role previously served
by CLUSTER_TYPE_K3S_BASE (marked for future phase-out). Generate Go and
Python bindings.