updating QEMU parameters and default path for the firmware#1058
updating QEMU parameters and default path for the firmware#1058AlissonMachadoEmbitel wants to merge 1 commit intolf-edge:masterfrom
Conversation
|
Hey @AlissonMachadoEmbitel thank you very much for your contribution! Couple of things:
git commit --amend --signoff
qemu-system-x86_64 --version |
Signed-off-by: AlissonMachadoEmbitel <alisson.machado@diconium.com>
19dd5c4 to
df35c18
Compare
|
Hi @uncleDecart , This is my current version: ➜ ~ qemu-system-x86_64 --version |
|
I think it's a valid concern and I've seen this issue before, but it works on my combo QEMU 10.0.2 on Linux. |
|
@europaul I run things on a remote linux machine. |
|
|
||
| DefaultQemuAccelDarwin = "-machine q35,accel=hvf -cpu kvm64,kvmclock=off " | ||
| DefaultQemuAccelDarwinArm64 = "-machine virt,accel=hvf,usb=off,dump-guest-core=off -cpu host " | ||
| DefaultQemuAccelDarwinArm64 = "-machine virt,accel=hvf,usb=off,dump-guest-core=on -cpu host " |
There was a problem hiding this comment.
This option is not needed for macOS. This just includes the guest memory in a core dump. The default is already on, but let's keep it off to be consistent with the options for Linux.
|
I tested on macOS, it works. @AlissonMachadoEmbitel , I know it's been a year from this PR, but if you are still interested, I just have one comment to be addressed and we are good to merge.... |
Hello,
I was facing a couple of issues when trying to run it on MacOS, then I made these fixes.
It was the same problem related on this issue: #1028