feat: redesign the logs using sh-style library#149
feat: redesign the logs using sh-style library#149levibostian wants to merge 18 commits intomainfrom
Conversation
now that Logger has new functions, has an init function, refactor codebase and tests to create the instances and provide them to test classes easily.
f188c96 to
cccb1ee
Compare
cccb1ee to
feef87b
Compare
should make tests pass much easier now.
…o download binary" This reverts commit 122a601.
decafRunning deployments in test mode. Results will appear below. ...🟩 squash 🟩 merge method... 🚢 The next version of the project will be: 0.13.0 Learn moreLatest release: 0.12.1 Commit of latest release: 3100912 Commits since last release: - feat: redesign the logs using sh-style library Related GitHub IssuesProblemI dont think the logs generated on the CI look good. the formatting can be hard to read and especially quickly glance over. SolutionI am not a designer and I dont necessarily enjoy designing things. So, I made a cli design system to make this easier and then this PR uses this library. Testing
Snapshot testing + viewing the logs from this PR. Notes for reviewers- chore(deps): update jdx/mise-action digest to 1648a78 (#158) This PR contains the following updates:
Configuration📅 Schedule: Branch creation - "every weekend" in timezone 🚦 Automerge: Enabled. ♻ Rebasing: Whenever PR is behind base branch, or you tick the 🔕 Ignore: Close this PR and you won't be reminded about this update
This PR was generated by Mend Renovate. Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> This PR contains the following updates:
Release Notesdenoland/deno (deno)
(#32808)
(#32817)
(#32806)
(#32572)
(#32749)
(#32702)
(#32599)
(#32713)
(#32325)
(#32618)
(#32791)
(#32606)
(#32535)
(#32244)
(#32632)
(#32450)
(#32776)
Configuration📅 Schedule: Branch creation - "every weekend" in timezone 🚦 Automerge: Enabled. ♻ Rebasing: Whenever PR is behind base branch, or you tick the 🔕 Ignore: Close this PR and you won't be reminded about this update
This PR was generated by Mend Renovate. Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> ...🟩 rebase 🟩 merge method... |
In a pull request of mine, I encountered a scenario where the squash simulated merge was failing with decaf. However, the GitHub UI for the pull request did not indicate there were merge conflicts for the squash method, though it did for the rebase. This, to me, proves that the current implementation of squash does not actually match what GitHub does. Therefore, I suggest changing the behavior to a new implementation.
## Related GitHub Issues <!-- Link to any related GitHub issues that this pull request addresses or closes. --> ## Problem <!-- A clear description of the problem that this pull request is solving. --> [In a pull request of mine](#149), I encountered a scenario where the squash simulated merge was failing with decaf. However, the GitHub UI for the pull request did not indicate there were merge conflicts for the squash method, though it did for the rebase. This, to me, proves that the current implementation of squash does not actually match what GitHub does. Therefore, I suggest changing the behavior to a new implementation. ## Solution <!-- Describe the approach you took to solve the problem and the changes made in this pull request. --> Implement `git merge --squash` as the new solution. ## Testing <!-- Choose one of the below options for how you tested the code change. Include any specific setup or instructions for testing. --> - [ ] Added automated tests. - [X] Manually tested. If you check this box, provide instructions for others to test, too. Sure, there are automated tests, but this change must be tested in a real PR to validate that it's the correct command. I can verify that it did [fix the problem I saw in the PR](#149). It's a simple solution, so I feel good about it. ## Notes for reviewers <!-- If there is any additional information you would like to share with the person reviewing this pull request, please provide it here. -->
5b2be51 to
ba7c583
Compare
7a8e3c6 to
3e3acbb
Compare
Related GitHub Issues
Problem
I dont think the logs generated on the CI look good. the formatting can be hard to read and especially quickly glance over.
Solution
I am not a designer and I dont necessarily enjoy designing things. So, I made a cli design system to make this easier and then this PR uses this library.
Testing
Snapshot testing + viewing the logs from this PR.
Notes for reviewers