Skip to content

Fix screen flicker when activating XDR overlay #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thomasl wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix screen flicker when activating XDR overlay #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 24 additions & 7 deletions Sources/main.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ if CommandLine.arguments.contains("--kill") || CommandLine.arguments.contains("-

class Renderer: NSObject, MTKViewDelegate {
var commandQueue: MTLCommandQueue
var onFirstFrame: (() -> Void)?
init(device: MTLDevice) { self.commandQueue = device.makeCommandQueue()! }
func mtkView(_ view: MTKView, drawableSizeWillChange size: CGSize) {}
func draw(in view: MTKView) {
Expand All @@ -28,6 +29,12 @@ class Renderer: NSObject, MTKViewDelegate {
if let drawable = view.currentDrawable {
buf.present(drawable)
}
if let callback = onFirstFrame {
onFirstFrame = nil
buf.addCompletedHandler { _ in
DispatchQueue.main.async { callback() }
}
}
buf.commit()
}
}
Expand Down Expand Up @@ -183,13 +190,15 @@ class XDRApp: NSObject, NSApplicationDelegate {

@objc func handleDisplayChange() {
maxEDR = NSScreen.main?.maximumPotentialExtendedDynamicRangeColorComponentValue ?? 1.0
if isActive {
deactivate()
if maxEDR > 1.0 && shouldBeActive {
DispatchQueue.main.asyncAfter(deadline: .now() + 0.5) { [weak self] in
self?.activate()
fputs("Display changed — XDR refreshed\n", stderr)
}
if isActive, shouldBeActive {
if maxEDR > 1.0, let screen = NSScreen.main {
// Resize the existing overlay to match the new screen layout
// instead of tearing down and recreating (which causes a flash)
overlayWindow?.setFrame(screen.frame, display: false)
boostView?.frame = screen.frame
fputs("Display changed — XDR resized\n", stderr)
} else {
deactivate()
}
}
}
Expand Down Expand Up @@ -251,10 +260,18 @@ class XDRApp: NSObject, NSApplicationDelegate {
boostView.wantsLayer = true
window.contentView = boostView
window.contentView?.layer?.compositingFilter = "multiply"

// Start invisible, reveal only after Metal renders the first frame
// to prevent a flash of transparent/black content
window.alphaValue = 0
window.orderFrontRegardless()
overlayWindow = window
self.boostView = boostView

boostRenderer?.onFirstFrame = { [weak window] in
window?.alphaValue = 1
}

isActive = true
statusItem.button?.title = "☀︎"
toggleItem.title = "Turn Off"
Expand Down