Skip to content

Minor update for offline persistance#30

Open
Zio-4 wants to merge 3 commits intomainfrom
fix-offline-persistence
Open

Minor update for offline persistance#30
Zio-4 wants to merge 3 commits intomainfrom
fix-offline-persistence

Conversation

@Zio-4
Copy link
Collaborator

@Zio-4 Zio-4 commented Oct 15, 2025

Proposed changes

This change allows documents to be written if the connection is lost and resumed in the same session.

Issue #646

Types of changes

What types of changes does this pull request introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that does not add functionality but makes code cleaner or more efficient)
  • Tests (new or updated tests)
  • Styles (changes to code styling)
  • CI (continuous integration changes)
  • Other (please describe below)

Additional Notes

@Zio-4 Zio-4 requested a review from asengupta3 October 15, 2025 22:17
Copy link

@asengupta3 asengupta3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So here was the confusion when I implemented it:

  1. We have "firebase": "^9.23.0" in this package
  2. But we have a newer version in node_modules/firebase/package.json in levante-dashboard which is 10.14

So v10 supports the persistentLocalCache but v9 does not. So I am not sure where the version mismatch happens but maybe we update the firestore version in this repo and make it consistent with dashboard?

I am also seeing a dependency on "@bdelab/roar-firekit": "^4.1.1", which can lead to some conflict in packages since they might use their own firebase version. Can we remove that too?

@Zio-4
Copy link
Collaborator Author

Zio-4 commented Oct 17, 2025

I think the ROAR tasks require ROAR FireKit. It's something we should test with if we can pass in our Firekit for the new versions of the ROAR tasks. Because they were overhauling Firelot on their side.

Regarding updating the version, I tested it with 10.14, but I'm still getting these errors when I log back in after doing trials offline. So maybe that's part of the issue, but it also has to be something else. I also tested the multiple tab manager, but that didn't fix it either.
Screenshot 2025-10-17 at 2 50 29 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants