Open
Conversation
asengupta3
reviewed
Oct 16, 2025
asengupta3
left a comment
There was a problem hiding this comment.
So here was the confusion when I implemented it:
- We have "firebase": "^9.23.0" in this package
- But we have a newer version in
node_modules/firebase/package.jsonin levante-dashboard which is10.14
So v10 supports the persistentLocalCache but v9 does not. So I am not sure where the version mismatch happens but maybe we update the firestore version in this repo and make it consistent with dashboard?
I am also seeing a dependency on "@bdelab/roar-firekit": "^4.1.1", which can lead to some conflict in packages since they might use their own firebase version. Can we remove that too?
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Proposed changes
This change allows documents to be written if the connection is lost and resumed in the same session.
Issue #646
Types of changes
What types of changes does this pull request introduce?
Additional Notes