Group creation has delay and allows duplicates#50
Merged
asengupta3 merged 3 commits intomainfrom Mar 31, 2026
Merged
Conversation
asengupta3
reviewed
Mar 12, 2026
| .limit(1) | ||
| .get(); | ||
|
|
||
| if (!existing.empty) { |
Collaborator
There was a problem hiding this comment.
Maybe move this out of the upsert-org function. That way it is a little cleaner to read?
asengupta3
reviewed
Mar 12, 2026
Collaborator
There was a problem hiding this comment.
I think this function can be written in a more human readable way. Right now it is so hard to read :) But that can be a followup PR.
Collaborator
|
@rolivares93 I think the changes look good but just for the sake of following the process, we should merge in main, deploy the latest functions to preview and test the front end against preview to make sure everything works. |
8 tasks
Contributor
Author
|
@asengupta3 could you approve this so we can merge it and test it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
I updated the upsertOrg function to check for existing orgs before creating them.
Ticket#818
Types of changes
What types of changes does this pull request introduce?
Additional Notes