dependencies: Update go-redis from v9.10.0 to v9.20.1#8815
Open
beautifulentropy wants to merge 1 commit into
Open
dependencies: Update go-redis from v9.10.0 to v9.20.1#8815beautifulentropy wants to merge 1 commit into
beautifulentropy wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly motivated by redis/go-redis#3403 a fix for redis/go-redis#3402 which was shipped in https://github.com/redis/go-redis/releases/tag/v9.12.0. At present this bug is causing us to swallow DialTimeout errors for pipelined Redis reads (the only kind of reads we do in Production). This results in an empty value being passed back to
*RedisSource.BatchGet()which cannot be parsed into anint64thus giving the appearance of empty Redis keys.Fixes #8816