Skip to content

Conversation

@shenanigansd
Copy link
Member

No description provided.

Signed-off-by: Bradley Reynolds <bradley.reynolds@tailstory.dev>
@shenanigansd shenanigansd self-assigned this Jan 15, 2026
Copilot AI review requested due to automatic review settings January 15, 2026 02:14
@shenanigansd shenanigansd enabled auto-merge (squash) January 15, 2026 02:14
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 15, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing br/ty (4b65e32) with main (0a6e822)

Summary

✅ 2 untouched benchmarks

@shenanigansd shenanigansd merged commit a2d61a1 into main Jan 15, 2026
24 checks passed
@shenanigansd shenanigansd deleted the br/ty branch January 15, 2026 02:14
@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.29%. Comparing base (0a6e822) to head (4b65e32).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #140   +/-   ##
=======================================
  Coverage   88.29%   88.29%           
=======================================
  Files           3        3           
  Lines          94       94           
=======================================
  Hits           83       83           
  Misses         11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds "ty" as a static analysis tool to the project's development workflow, integrating it alongside existing linting tools like mypy, ruff, and prek.

Changes:

  • Added ty>=0.0.12 to development dependencies in pyproject.toml
  • Integrated ty check . command into the nox linting session
  • Added a dedicated "Run ty" step in the GitHub Actions CI workflow

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
pyproject.toml Added ty package to dev dependency group
uv.lock Added ty package metadata and wheel information for multiple platforms
noxfile.py Added ty check command to the lints session
.github/workflows/python-ci.yaml Added ty check step to the lint job

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

session.run("ruff", "check", "--fix", ".")
session.run("ruff", "format", ".")
session.run("mypy", "--strict", "src/")
session.run("ty", "check", ".")
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The noxfile adds a new static analysis tool 'ty', but there is no configuration for this tool in pyproject.toml (unlike other tools such as [tool.mypy] or [tool.ruff]). If 'ty' requires configuration, consider adding a [tool.ty] section to pyproject.toml with appropriate settings. If no configuration is needed, this comment can be disregarded.

Suggested change
session.run("ty", "check", ".")

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants