Skip to content

Conversation

@shenanigansd
Copy link
Member

No description provided.

Signed-off-by: Bradley Reynolds <bradley.reynolds@tailstory.dev>
@shenanigansd shenanigansd self-assigned this Jan 15, 2026
Copilot AI review requested due to automatic review settings January 15, 2026 01:47
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 15, 2026

Merging this PR will improve performance by 10.23%

⚡ 1 improved benchmark
✅ 1 untouched benchmark

Performance Changes

Benchmark BASE HEAD Efficiency
test_stutter[1.0-I love dogs-I l-love d-dogs] 130.3 µs 118.2 µs +10.23%

Comparing br/matrix-but-codecov (6339294) with main (20c05c8)

Open in CodSpeed

@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.29%. Comparing base (20c05c8) to head (6339294).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #137   +/-   ##
=======================================
  Coverage   88.29%   88.29%           
=======================================
  Files           3        3           
  Lines          94       94           
=======================================
  Hits           83       83           
  Misses         11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the CI workflow to separate linting and testing into distinct jobs, implements a test matrix for Python versions 3.10-3.14, and optimizes Codecov uploads to only include Python 3.12 coverage reports.

Changes:

  • Split the lint-test job into separate lint and test jobs for better parallelization
  • Added a test matrix to run tests across Python versions 3.10, 3.11, 3.12, 3.13, and 3.14
  • Created a separate codecov job that downloads and uploads only Python 3.12 coverage and test results to Codecov

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Bradley Reynolds <bradley.reynolds@tailstory.dev>
Signed-off-by: Bradley Reynolds <bradley.reynolds@tailstory.dev>
Copilot AI review requested due to automatic review settings January 15, 2026 02:00
@shenanigansd shenanigansd merged commit b879849 into main Jan 15, 2026
24 checks passed
@shenanigansd shenanigansd deleted the br/matrix-but-codecov branch January 15, 2026 02:02
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

if: ${{ !cancelled() }}
uses: actions/download-artifact@37930b1c2abaa49bbe596cd826c3c89aef350131 # v7.0.0
with:
name: coverage-py3.14
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title indicates that coverage from Python 3.12 should be uploaded to Codecov, but this downloads coverage from Python 3.14 instead. This should be changed to "coverage-py3.12" to match the PR's stated intent.

Suggested change
name: coverage-py3.14
name: coverage-py3.12

Copilot uses AI. Check for mistakes.
Comment on lines +100 to +105
- name: Download coverage reports
if: ${{ !cancelled() }}
uses: actions/download-artifact@37930b1c2abaa49bbe596cd826c3c89aef350131 # v7.0.0
with:
name: coverage-py3.14
path: coverage
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The codecov job uses "if: always()" which means it will run even if the test job fails. However, the download-artifact step uses "if: !cancelled()" which may cause issues if the test job fails and no artifact is produced. Consider adding a check to ensure the artifact exists before attempting to download, or adjust the condition to handle cases where tests fail for Python 3.12.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants