feat: add/remove repository to existing workspace #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lerenn
force-pushed
the
feat-add-repos-to-existing-workspace
branch
from
50f6b6c to
ac2b996
Compare
lerenn
changed the title
- Fixed TestAddRepositoryToWorkspaceWithWorktrees to handle local branches correctly - Fixed TestAddRepositoryToWorkspaceNoMatchingBranches to skip worktrees for non-existent branches - Added support for checking branches in original repository path before cloning - Improved branch existence validation to handle both local and remote branches - Made worktree creation idempotent by checking status before creation - Added verification to remove worktrees for non-existent branches from status - Refactored complex functions to reduce cyclomatic and cognitive complexity - Fixed all linting issues (line length, complexity, nested if statements) - All TestAddRepositoryToWorkspace* tests now pass
- Fixed TestWorktree_Create_DirectoryExists to include GetWorktree mock - Updated all TestAddRepositoryToWorkspace* tests to include mocks for: - GetRepository at start of createWorktreesForBranches - GetMainRepositoryPath for branch checks - BranchExists before and after worktree creation - verifyAndCleanupWorktree calls - Fixed TestCreateWorkspace* tests to include mocks for cloning process: - GetRepository with original and normalized URLs - GetDefaultBranch, MkdirAll, Clone - Updated remote URLs to use full HTTPS format for proper normalization All unit tests now pass with the new branch existence validation logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new commands to the CM CLI:
Features
cm ws add [-w workspace_name] [repository_name]cm ws remove [-w workspace_name] [repository_name]Implementation Details
pkg/code-manager/workspace_add.goandpkg/code-manager/workspace_remove.gocmd/cm/workspace/add.goandcmd/cm/workspace/remove.go