feat: add support for ssh:// URL format in repository cloning #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for ssh://git@host/path URL format in the normalizeRepositoryURL function. This allows users to clone repositories using the explicit ssh:// protocol prefix, which is useful for custom Git servers and specific SSH configurations. Changes: - Updated normalizeRepositoryURL to parse ssh:// URLs using url.Parse - Handle port numbers in ssh:// URLs (e.g., ssh://git@host:22/path) - Normalize ssh:// URLs to host/path format consistent with other formats - Added unit tests for ssh:// URL formats (with/without .git, with port) - Added E2E test for ssh:// URL format This fixes the issue where cloning with ssh://git@forge.lab.home.lerenn.net/homelab/lgtm.git would fail with 'unsupported repository URL format' error.
Extract URL normalization logic into separate helper functions to reduce cyclomatic complexity from 12 to below the limit of 10. - Extract normalizeSSHProtocolURL for ssh:// URLs - Extract normalizeSSHURL for git@host:path URLs - Extract normalizeHTTPSURL for https:// URLs - Add isSSHURL helper function for URL type detection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for
ssh://URL format in repository cloning, allowing users to clone repositories using the explicitssh://protocol prefix.Problem
The
normalizeRepositoryURLfunction only supported:git@host:pathformat (SSH without protocol)https://host/pathformat (HTTPS)It did not support
ssh://git@host/pathformat, causing errors when trying to clone repositories like:Solution
normalizeRepositoryURLto parsessh://URLs usingurl.Parsessh://URLs (e.g.,ssh://git@host:22/path)ssh://URLs tohost/pathformat consistent with other formatsTesting
ssh://URL formats:ssh://URL formatChanges
pkg/code-manager/clone.go- UpdatednormalizeRepositoryURLfunctionpkg/code-manager/clone_test.go- Added unit teststest/repo_clone_test.go- Added E2E test