fix(status): make debug logging verbose-only #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add logger field to status.Manager and SetLogger method - Replace all log.Printf calls with verbose logger calls in: - remove_worktree.go (5 log statements) - update_workspace.go (2 log statements) - remove_workspace.go (2 log statements) - saveStatus in status.go (fmt.Printf) - Update code-manager.SetLogger to also set logger on status manager - Regenerate mocks to include SetLogger method All debug logging statements now only execute when verbose mode is enabled, preventing unnecessary output in normal operation.
Refactored RemoveWorktree to reduce cyclomatic complexity from 12 to below 10 by extracting helper functions: - validateRepository: validates repository existence - deleteWorktreeFromRepo: handles worktree deletion logic - logRemoveWorktreeBefore/After/Delete/Save: extracted logging helpers This addresses the cyclop linter error while maintaining the same functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes debug logging in the status package to only output in verbose mode.
Changes
status.ManagerandSetLoggermethodlog.Printfcalls with verbose logger calls in:remove_worktree.go(5 log statements)update_workspace.go(2 log statements)remove_workspace.go(2 log statements)saveStatusinstatus.go(fmt.Printf)code-manager.SetLoggerto also set logger on status managerSetLoggermethodImpact
All debug logging statements now only execute when verbose mode is enabled, preventing unnecessary output in normal operation.