fix(test): resolve WaitGroup race condition and update Kafka TLS config #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ure Dagger module - Replace deprecated bitnami/kafka:3.5.1 with confluentinc/cp-kafka:7.5.0 - Update docker-compose.yaml with Confluent Platform configuration for KRaft mode - Update .dagger/brokers.go to use Confluent images and environment variables - Move Dagger module from build/ci/dagger/ to .dagger/ at project root - Integrate test utilities into .dagger/testutil.go to avoid replace directive issues - Update GitHub Actions workflow to use .dagger instead of build/ci - Add dagger/all Makefile target to run all CI checks locally - Add .dagger/ to .gitignore - Remove build/ci directory
- Add sync.Once to ensure wg.Done() is only called once - Refactor generate-certs tool to fix linting issues - Extract helper functions to reduce complexity and improve maintainability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This PR fixes a race condition in the test suite and updates Kafka TLS configuration to use JKS format.
Changes:
Testing: All tests pass locally, linting passes, code generation is up to date