Repository navigation
fix(laravel): keep Horizon to sites that queue to Redis - #106
Merged
Merged
Conversation
Horizon only reads Redis queues, so on a site with QUEUE_CONNECTION=database it ran while the jobs sat in the table. Horizon's check and the queue worker's exclude_check now carry when_env: QUEUE_CONNECTION=redis, so a lerd that understands the key runs the queue worker on any other connection. Each rule keeps its composer match, so an older lerd that drops when_env reads exactly the rule it reads today. The Horizon package also gains a doctor warning for QUEUE_CONNECTION=database, which tells users on an older lerd why their jobs are not being processed. Refs lerd-env/lerd#2428
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Horizon only reads Redis queues, so on a site with QUEUE_CONNECTION=database it ran while the jobs sat in the table. Horizon's check and the queue worker's exclude_check now carry when_env: QUEUE_CONNECTION=redis across every Laravel major and the Horizon package, so a lerd that understands the key runs the queue worker on any other connection. Each rule keeps its composer match, so lerd 1.38 and older read exactly the rule they read today.
The Horizon package also gains a doctor warning for QUEUE_CONNECTION=database, which tells users on an older lerd why their jobs are not being processed. Once the binary side has been out for a while the warning can go, since on a new lerd the queue worker already handles that case.
Refs lerd-env/lerd#2428