fix(controls): Fix ProgressRing not restarting properly when visibily changes#1678
Open
Nuklon wants to merge 2 commits intolepoco:mainfrom
Open
fix(controls): Fix ProgressRing not restarting properly when visibily changes#1678Nuklon wants to merge 2 commits intolepoco:mainfrom
Nuklon wants to merge 2 commits intolepoco:mainfrom
Conversation
github-actions
bot
added
controls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
If you hide an indeterminate progress ring (e.g., after loading is done), and then show it again, the progress ring doesn't restart the animation properly, rendering a partial progress ring (+ looks like broken animation) due to the angle not getting reset.
What is the new behavior?
Restart the animation after visibily changed (reuses the IsEnabled path).