Openstud: Add support for attending modes in exam reservations#27
Open
matypist wants to merge 5 commits intoleosarra:masterfrom
Open
Openstud: Add support for attending modes in exam reservations#27matypist wants to merge 5 commits intoleosarra:masterfrom
matypist wants to merge 5 commits intoleosarra:masterfrom
Conversation
Author
|
See also leosarra/openstud_client#33 |
leosarra
reviewed
Mar 8, 2023
Owner
leosarra
left a comment
leosarra
left a comment
There was a problem hiding this comment.
Sorry but I went through the commit again and I noticed a small thing worth changing 😄
Also, in case you are not aware, there is no need to close the PR in order to add some additional changes to it, you just need to push the commit in the branch of your fork and this PR should pick it up automatically
| private String ssd; | ||
| private String module; | ||
|
|
||
| private JSONArray attendingModesList; |
Owner
There was a problem hiding this comment.
Instead of relying on JSONArray from the jsoup lib to expose the information I think it would be better to use the Java stdlib (List<String>)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #25