-
Notifications
You must be signed in to change notification settings - Fork 25
Add a contributing file #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
neelr
wants to merge
1
commit into
leomvit:master
Choose a base branch
from
neelr:add-contributing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| # Contributing | ||
|
|
||
| Thanks for considering contributing to leomvit.github.io! | ||
|
|
||
| ## Opening issues | ||
|
|
||
| If you find a bug, please feel free to [open an issue](https://github.com/leomvit/leomvit.github.io/issues). | ||
|
|
||
| If you taking the time to mention a problem, even a seemingly minor one, it is greatly appreciated, and a totally valid contribution to this project. Thank you! | ||
|
|
||
| ## Fixing bugs | ||
|
|
||
| We love pull requests. Here’s a quick guide: | ||
|
|
||
| 1. [Fork this repository](https://github.com/leomvit/leomvit.github.io/fork) and then clone it locally: | ||
|
|
||
| ```bash | ||
| git clone https://github.com/abcd/leomvit.github.io | ||
| ``` | ||
|
|
||
| 2. Create a topic branch for your changes: | ||
|
|
||
| ```bash | ||
| git checkout -b fix-for-that-thing | ||
| ``` | ||
|
|
||
| 3. Commit a fix that makes the test pass: | ||
|
|
||
| ```bash | ||
| git commit -am "Adds a fix for that thing!" | ||
| ``` | ||
|
|
||
| 4. Run the tests, and check if the website looks good | ||
|
|
||
| 5. If everything looks good, push to your fork: | ||
|
|
||
| ```bash | ||
| git push origin fix-for-that-thing | ||
| ``` | ||
|
|
||
| 6. [Submit a pull request.](https://help.github.com/articles/creating-a-pull-request) | ||
|
|
||
| 7. Enjoy being the wonderful person you are | ||
|
|
||
| ## Adding new features | ||
|
|
||
| Thinking of adding a new feature? Cool! [Open an issue](https://github.com/leomvit/leomvit.github.io/issues) and let’s design it together. | ||
|
|
||
| **Thanks to [default](https://github.com/kennethormandy/default) for the template!** | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @neelr . Thanks for adding this file! @AvikantSrivastava just added a pull request template and an issue template to this project (see #93 ). Can you mention those somewhere here, instead of the default template? Also I am requesting an additional review from @AvikantSrivastava , he may just want you to add specific details relevant to the project or the community if necessary.