Open
Conversation
orapps44
requested changes
Feb 24, 2022
Collaborator
orapps44
left a comment
orapps44
left a comment
There was a problem hiding this comment.
Hi, thanks for this great job.
I thinks this new feature may have an interest for users.
However I suggest to change property name UsePreProcessIcons by something like UseColorIcons. This new property should also be set to false by default.
Use Preproces Icons True par defaut
Author
|
Hi, I fixed the property default True, because in google guideline the icons are monochrome. It's when property is false than the icons are colored and not trasform. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhancements:
Added DrawerUsePreProcessIcon for use colored icon