Skip to content

Adds placeHolder attribute in the WebCachedImageView#1

Open
lpmfilho wants to merge 1 commit into
leocadiotine:masterfrom
lpmfilho:master
Open

Adds placeHolder attribute in the WebCachedImageView#1
lpmfilho wants to merge 1 commit into
leocadiotine:masterfrom
lpmfilho:master

Conversation

@lpmfilho
Copy link
Copy Markdown

It was added the "placeHolder" attribute in the WebCachedImageView to allow the user to set, by XML Layout, a default image while the requested image is downloaded.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must check here if placeholder is null. If it is, must set the alpha to zero.

@leocadiotine
Copy link
Copy Markdown
Owner

You're the man! This was on my todo list, exactly like this. Thanks!

But there is one thing: unfortunately this pull request removes the Animation code I wrote… If you have the time and want to fix it on another pull request, it'd be great! If you don't, don't worry. I already thought of a way to keep both the animation and the placeholder. I can do this on monday.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

url can't be null here, because of the way cancelPotentialWork gets called.

@FardadJalili
Copy link
Copy Markdown

I think when we have a placeholder we should have a policy about when setImageUrl is called with a null reference, maybe cancel the task and show the placeholder?
Something like that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants