Skip to content

Fixed race conditions #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
riquito wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixed race conditions #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
02188b8
Don't let the shell evaluate arguments
Jun 10, 2013
2054681
Avoid printf since we can't both format strings and escape printf spe…
Jun 10, 2013
df02b94
Interpretation of backslash escapes
Jun 10, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions assert.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,8 @@ assert() {
# assert <command> <expected stdout> [stdin]
(( tests_ran++ ))
[[ -n "$DISCOVERONLY" ]] && return
# printf required for formatting
printf -v expected "x${2:-}" # x required to overwrite older results
result="$(eval 2>/dev/null $1 <<< ${3:-})"
expected=$(echo -e "x${2:-}") # x required to overwrite older results
result=$(echo -e "$(eval 2>/dev/null "$1" <<< ${3:-})")
# Note: $expected is already decorated
if [[ "x$result" == "$expected" ]]; then
[[ -n "$DEBUG" ]] && echo -n .
Expand Down
3 changes: 3 additions & 0 deletions tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ assert "seq 2" "1\n2" # multi-line output expected
assert_raises 'read a; exit $a' 42 "42" # variables still work
assert "echo 1;
echo 2 # ^" "1\n2" # semicolon required!
assert 'echo " * "' " * " # don't let the shell evaluate arguments
assert "echo '%s --'" "%s --" # don't escape user content
assert "echo \"foo\nbar\"" "foo\nbar" # interpretation of backslash escape
assert_end demo

_clean() {
Expand Down