Skip to content

Merge push-uvsomptkxqvs Into main#91

Merged
dclong merged 1 commit into
mainfrom
push-uvsomptkxqvs
Jun 21, 2026
Merged

Merge push-uvsomptkxqvs Into main#91
dclong merged 1 commit into
mainfrom
push-uvsomptkxqvs

Conversation

@dclong

@dclong dclong commented Jun 21, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@dclong dclong force-pushed the push-uvsomptkxqvs branch from 89d8b4b to f18d9c0 Compare June 21, 2026 03:33

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces client-side validation for GitHub secret names to prevent 422 errors from the GitHub API. It adds a _validate_secret_name helper function using a regular expression to enforce naming rules, integrates this validation into secret creation/update methods, and adds comprehensive unit tests. The package version in uv.lock is also bumped. The reviewer feedback points out two import sorting violations that conflict with the project's strict adherence to Ruff formatting rules: one in github_rest_api/github.py regarding standard library import grouping, and another in tests/test_github.py regarding the alphabetical sorting of imported names.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread github_rest_api/github.py Outdated
Comment thread tests/test_github.py
Add client-side validation for GitHub secret names in repository and organization secret creation methods to catch invalid names (e.g. starting with digits or "GITHUB_") before triggering API errors.
@dclong dclong force-pushed the push-uvsomptkxqvs branch from f18d9c0 to e04e3c8 Compare June 21, 2026 06:08
@dclong

dclong commented Jun 21, 2026

Copy link
Copy Markdown
Collaborator Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request configures Ruff to sort imports, applies import sorting across the codebase, and introduces client-side validation for GitHub secret names via a new _validate_secret_name function. The feedback suggests extending this validation to enforce GitHub's 100-character maximum length limit for secret names and adding a corresponding test case to verify this behavior.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread github_rest_api/github.py
Comment thread tests/test_github.py
@dclong dclong merged commit ba34b67 into main Jun 21, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant