Skip to content

Merge push-xlyrmloqotrx Into main#89

Merged
dclong merged 1 commit into
mainfrom
push-xlyrmloqotrx
Jun 21, 2026
Merged

Merge push-xlyrmloqotrx Into main#89
dclong merged 1 commit into
mainfrom
push-xlyrmloqotrx

Conversation

@dclong

@dclong dclong commented Jun 21, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a get_secrets method to both repository and organization contexts in github_rest_api/github.py to retrieve secrets. To support this, the internal _extract_all pagination helper was updated to accept an optional key parameter for extracting nested lists from JSON responses. The review feedback suggests implementing defensive type and key checks when extracting items from the API response to prevent potential KeyError or TypeError exceptions if the response structure is unexpected.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread github_rest_api/github.py
* Add `get_secrets` to list secrets in organizations and repositories.
* Update `_extract_all` pagination helper to support nested lists via the `key` parameter.
@dclong dclong force-pushed the push-xlyrmloqotrx branch from afc8ee0 to 2062e6c Compare June 21, 2026 01:50
@dclong dclong merged commit 9d2d8f4 into main Jun 21, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant