Skip to content

output: store number of events in LH5 file#629

Merged
ManuelHu merged 1 commit intomainfrom
nevents
Mar 10, 2026
Merged

output: store number of events in LH5 file#629
ManuelHu merged 1 commit intomainfrom
nevents

Conversation

@ManuelHu
Copy link
Copy Markdown
Contributor

not fully implemented yet in the post-processing, but we should be able to discuss it on this draft already.

fixes #615

@ManuelHu ManuelHu requested a review from tdixon97 February 26, 2026 10:23
Comment thread src/RMGConvertLH5.cc Outdated
@ManuelHu ManuelHu force-pushed the nevents branch 2 times, most recently from da0431f to 80046f2 Compare March 2, 2026 21:17
@ManuelHu ManuelHu marked this pull request as ready for review March 9, 2026 21:33
@ManuelHu ManuelHu added output lh5 LH5 output specific labels Mar 10, 2026
@ManuelHu
Copy link
Copy Markdown
Contributor Author

@gipert this should now be ready!

@ManuelHu ManuelHu merged commit 508d38b into main Mar 10, 2026
7 of 9 checks passed
@ManuelHu ManuelHu deleted the nevents branch March 10, 2026 14:17
@gipert
Copy link
Copy Markdown
Member

gipert commented Apr 10, 2026

missing: a note about this in the manual section about output.

also i find number_of_events not so clear as a name. which events? maybe number_of_primaries is clrearer? or nr_sim_events?

cc @tdixon97

@ManuelHu
Copy link
Copy Markdown
Contributor Author

number_of_primaries would be misleading, as an event can contain more than one primary (i.e. from bxdecay0 or other external event generators)

@gipert
Copy link
Copy Markdown
Member

gipert commented Apr 10, 2026

maybe then we should clearly state that these are simulated events? i think with the current name an user could think that these are detected events

@ManuelHu
Copy link
Copy Markdown
Contributor Author

yeah, I will add some docs in my pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lh5 LH5 output specific output

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Number of primaries

2 participants