Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds hemisphere support to the cosmic muons generator (EcoMug). The generator previously only supported plane-based muon generation, and now also supports hemisphere-based generation centered at the origin.
Changes:
- Added sphere/hemisphere generation mode to the EcoMug cosmic muon generator
- Moved sphere position angle configuration (theta/phi) to be specific to sphere mode rather than global
- Added new parameter
SkyHSphereRadiusto configure the hemisphere radius - Updated documentation to clarify supported generation modes
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/RMGGeneratorCosmicMuons.cc | Implemented sphere support with case statement, moved sphere-specific angle settings to sphere case, added new SkyHSphereRadius parameter |
| include/RMGGeneratorCosmicMuons.hh | Added fSkyHSphereRadius member variable with default value and brief documentation comment |
| docs/manual/generators.md | Added documentation about supported generation modes (plane/hemisphere) and usage notes for EcoMug |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ManuelHu
reviewed
Feb 14, 2026
Contributor
ManuelHu
left a comment
ManuelHu
left a comment
There was a problem hiding this comment.
also needs a regenerate of the command docs with make remage-doc-dump
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently have almost no tests for this code, should we atleast check it runs ?