Add julia script for ideal Pulse Shape Library generation

[SalehGiovanna]

Julia script to build ideal Pulse Shape Library using ssd

Realistic PSL construction from ideal (py) ---> Moved to separate PR

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.96%. Comparing base (d7a810d) to head (88133c7).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
+ Coverage   67.13%   67.96%   +0.82%     
==========================================
  Files          23       23              
  Lines        2054     2060       +6     
==========================================
+ Hits         1379     1400      +21     
+ Misses        675      660      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[tdixon97]

Can you run pre-commit locally, this will include checks on the julia code and formatting

[Copilot]

Pull request overview

This pull request adds two new scripts for HPGe pulse shape modeling to create a Pulse Shape Library (PSL). The scripts work together to generate realistic waveform maps from ideal simulated waveforms.

Changes:

• Added make_hpge_ideal_wf_map.jl to generate ideal waveform maps from SolidStateDetectors simulations
• Added make_hpge_realistic_wf_map.py to transform ideal waveform maps into realistic ones through convolution with electronics response

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 29 comments.

File	Description
workflow/src/legendsimflow/scripts/make_hpge_ideal_wf_map.jl	Julia script that simulates ideal charge waveforms for HPGe detectors at different crystal axis angles using SolidStateDetectors, normalizes them, and saves to LH5 format
workflow/src/legendsimflow/scripts/make_hpge_realistic_wf_map.py	Python script that processes ideal waveform maps by convolving with system response kernels, converting to current waveforms, applying moving window averaging, and aligning peaks to create realistic PSL compatible with reboost

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 19 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[gipert]

see #91

[SalehGiovanna]

@gipert I saw it, but I am not using those functions in my script, even though its true that there is a lot of shared code.
So the possibilities I see are:

• Merge this and Refactor drift time map script into library and add map extension function #91 separately and then modify the functions in the libjl to be usable both for the dt map and for the wfs map [best solution in my opinion]
• Add my functions for the wfs map construction (currently in make_hpge_ideal_wf_map.jl) to libjl and modify my script to include them from there

[gipert]

Yes, the first is the right solution

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 15 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[tdixon97]

@SalehGiovanna I rebased this onto #95. I think its in a great shape, I can quickly make the last fixes then we are done with this (we can add tests in a further PR)

[tdixon97]

Just some small comments to remove the outdated options, this would also align with the dt map script

[gipert]

after #95 got merge the situation got messy, i work on a rebase now

[tdixon97]

@gipert now the commits are just by you and Claude, do you know how to fix this to be Giovanna?
I suppose its due to rebasing?
By the way @SalehGiovanna and I discussed a refactoring to resolve almost all comments, she will implement it today I think

[SalehGiovanna]

@tdixon97 yes i'm doing it now, I did not commit anything yet because I saw there was ongoing work, now i do it

[gipert]

I fixed the authors. I just have a chat with @SalehGiovanna, she is gonna pick the work up from the current status here.

[tdixon97]

Now the authors is me and you Luigi? Should be Giovanna

[gipert]

The first commit is giovanna's work and she's an author there

[hervasa2]

Very nice! Please see minor requested changes and comments from the SSD side

[hervasa2]

I would move to merge this asap and then to switch to the new ssd on everything on a subsequent PR

[tdixon97]

We first need to remove the duplicate code and add (atleast basic) tests. For example even a test the code runs is valuable

[gipert]

important missing thing: extend the PSL outside its bounds as done at the end of the function that makes the dt map

[SalehGiovanna]

But then how do we handle those waveforms?

[tdixon97]

I added a few (basic) tests, that the ssd code runs

[hervasa2]

But then how do we handle those waveforms?

You don's simulate those waveforms. You just copy the waveform from the nearest pixel inside the detector, just like the dt map (but with a waveform instead of the dt)

[SalehGiovanna]

But isn't it better to have waveforms outside the detector volume being jus NaNs, so they are easy to identify later?

[gipert]

But isn't it better to have waveforms outside the detector volume being jus NaNs, so they are easy to identify later?

no, the pixelation will always leave some holes in valid areas of the detector, so we want to extend the domain to be safe