Skip to content

Implement podcast index search#33

Merged
leftouterjoins merged 9 commits intodevelopmentfrom
codex/add-podcast-search-and-subscription-feature
Jun 17, 2025
Merged

Implement podcast index search#33
leftouterjoins merged 9 commits intodevelopmentfrom
codex/add-podcast-search-and-subscription-feature

Conversation

@leftouterjoins
Copy link
Owner

Summary

  • add podcast index search module
  • expose /search route and template
  • include search form on home page
  • provide empty config keys for podcast index credentials
  • add basic unit test for search class

Testing

  • composer test

https://chatgpt.com/codex/tasks/task_e_68517ead07e88322a3634f593aad74e3

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@leftouterjoins leftouterjoins force-pushed the codex/add-podcast-search-and-subscription-feature branch from 04580d1 to 15e8422 Compare June 17, 2025 18:58
@cursor
Copy link

cursor bot commented Jun 17, 2025

🚨 BugBot couldn't run

Something went wrong. Try again by commenting "bugbot run", or contact support (requestId: serverGenReqId_cc607986-bc92-4030-84df-28bc56e753a4).

@leftouterjoins
Copy link
Owner Author

bugbot run

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Method Parameter Overwritten with Hardcoded Value

The getSegments method's $categories parameter, despite having a default value, is immediately overwritten with the same hardcoded array. This makes the parameter useless, as any custom categories passed by the caller are ignored, preventing customization of segment retrieval.

src/Brickner/Podsumer/SponsorBlock.php#L20-L23

*/
public static function getSegments(string $videoId, array $categories = ['sponsor', 'selfpromo', 'interaction', 'intro', 'outro']): array
{
$categories = ['sponsor', 'selfpromo', 'interaction', 'intro', 'outro'];

Fix in Cursor


Was this report helpful? Give feedback by reacting with 👍 or 👎

@leftouterjoins leftouterjoins merged commit b8be3b9 into development Jun 17, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant