Merged
Conversation
Signed-off-by: Josh Brickner <15388+leftouterjoins@users.noreply.github.com>
There was a problem hiding this comment.
Bug: Image Source Logic Error
The episodes.html.php template incorrectly checks for $item['item_image'] to determine the image source. The State::getAllItems() query only returns COALESCE(items.image, feeds.image) AS image, so the field item_image does not exist in the result set. This causes the condition !empty($item['item_image']) to always be false, forcing image URLs to always use feed_id instead of item_id even when an item has its own image.
templates/episodes.html.php#L9-L10
podsumer/templates/episodes.html.php
Lines 9 to 10 in 35846f6
Was this report helpful? Give feedback by reacting with 👍 or 👎
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
composer testhttps://chatgpt.com/codex/tasks/task_e_685173737bbc83228cd57bcf831728c2