Skip to content

Conversation

@AmberIsFrozen
Copy link
Contributor

Introduced in d1ea76d

Since text node is also a type of child node, HasChildNodes would always be true even with the old way of specifying plugin (<plugin>path_to_plugin.dll</plugin>), which cause existing train XML to fail to load.

Changes it to look for child XML Elements instead, if not then fallback to the old way of loading plugin using InnerText.

@leezer3 leezer3 merged commit fcc000a into leezer3:master Jan 19, 2026
5 checks passed
@leezer3
Copy link
Owner

leezer3 commented Jan 20, 2026

Thanks.

As a note, I'm going to junk all the XML parsers in favor of block format soon:
#1214

Doing it that way has initial pain, but makes the thing so much more maintainable; you can only make the same mistake once....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants