Fix: Regression in XML train plugin parsing #1232
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced in d1ea76d
Since text node is also a type of child node,
HasChildNodeswould always be true even with the old way of specifying plugin (<plugin>path_to_plugin.dll</plugin>), which cause existing train XML to fail to load.Changes it to look for child XML Elements instead, if not then fallback to the old way of loading plugin using InnerText.