-
Notifications
You must be signed in to change notification settings - Fork 61
Change: Remove Legacy GL1.2 Renderer #1163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
cfc994c to
1c87998
Compare
|
This is partially working on Apple at this point. Investigating, but definitely not mergable at the moment. |
Chucks a GL.InvalidEnum on core context, handled below
|
I do not support this change, because that would mean dropping support for toasters (I recently got a perfectly fine 2014ish decent Sony Vaio laptop that I found thrown away, and for some reason it refuses to use the new renderer (I checked both on Windows and on Linux Mint and Route Viewer says that the new renderer isnt available)). Isnt the project about compability, or the compability is for BVE Routes only? |
|
It really depends on what you mean by compatability. The current version has good compatability with most BVE content. I don't have a good answer for the 'oldest' machine we should support, but something 11 years old is most likely out of mainstream support with Windows, and pushing it for running one of the heavier Linux desktop environments. Not merging this yet, and if this goes ahead, I suspect that we'd need to link from the main site the last compatability build. |
|
Why is OpenGL 4.3 being used specifically in the first place? And why you/we cant just use 4.0 or even 3.0 instead? |
|
I used 4.3 when implementing keyframe animations, for shader storage buffer support This PR revises it to 4.1, and uses uniform buffer objects instead, as well as dropping the GL1.2 code. The GL3 message needs updating. |
This PR removes completely the GL1.2 renderer.
Rationale:
Risks: