fix: query pkg update, incl. min fee on bytes logic#6346
fix: query pkg update, incl. min fee on bytes logic#6346kyranjamie wants to merge 1 commit intodevfrom
Conversation
|
@kyranjamie I tested some cases: In legacy dialogue and in the SIP010 send flow we have this (general) notice when a fee is set below the suggested value, we do not have this kind of notice/warning in the new fee setting flow. I think we should. With a custom setting the user can set it lower than suggested, and I can set it lower than 1uSTX/byte, (leading to "transaction rejected" error). It would be better to prevent that too or atleast show the same notice. It is probably overengineering to show this notice for anything below suggested and then a red one when the user even tries to set one below 1uSTX/byte the first one seems sufficient or with a small adaptation "Transaction may get delayed or fail" although we are certain it will fail when it is set to <1uSTX/byte. |
|
Thanks for QA Werner, indeed forgot about the case with custom fees. Will get back to this after we get release out and hopefully quash BadNonce errors |

cc @314159265359879 included in this is the min tx fee bytes logic for QA