Skip to content
This repository was archived by the owner on Apr 22, 2026. It is now read-only.

fix: query pkg update, incl. min fee on bytes logic#6346

Open
kyranjamie wants to merge 1 commit intodevfrom
fix/min-fee-improvements
Open

fix: query pkg update, incl. min fee on bytes logic#6346
kyranjamie wants to merge 1 commit intodevfrom
fix/min-fee-improvements

Conversation

@kyranjamie
Copy link
Copy Markdown
Contributor

@kyranjamie kyranjamie commented Aug 26, 2025

Try out Leather build ace06ccExtension build, Test report, Storybook, Chromatic

cc @314159265359879 included in this is the min tx fee bytes logic for QA

@314159265359879
Copy link
Copy Markdown
Contributor

@kyranjamie I tested some cases:
✅ Large contract calls, no fees below 1ustx/byte are suggested when I retested these borrow transactions: #6198 and #6251 and withdraw transactions which are both over 2999 bytes and used to be an issue if setting a low fee (due maxLow fee cap).
❌ SIP010 transfer with Memo: This is not yet resolved (see reproduction steps): #6181, memo size is not accounted for when fee is estimated. SIP010 tokens sending is relying on the legacy fee dialogue, is this also expected to be fixed in the legacy fee UX?
❌ No warning for custom fees below 1uSTX/byte.
I tested a contract deployment with the new fee setting UX, in this case (with smaller contract 400 lines than what fails in #6149 (comment), so it isn't rejected for being to big) it doesn't prevent the user from setting a custom fee below 1uSTX/byte, do we want to prevent that? We show a warning in the legacy method not in the new method.

In legacy dialogue and in the SIP010 send flow we have this (general) notice when a fee is set below the suggested value, we do not have this kind of notice/warning in the new fee setting flow. I think we should.
image

With a custom setting the user can set it lower than suggested, and I can set it lower than 1uSTX/byte, (leading to "transaction rejected" error). It would be better to prevent that too or atleast show the same notice.

It is probably overengineering to show this notice for anything below suggested and then a red one when the user even tries to set one below 1uSTX/byte the first one seems sufficient or with a small adaptation "Transaction may get delayed or fail" although we are certain it will fail when it is set to <1uSTX/byte.

@kyranjamie
Copy link
Copy Markdown
Contributor Author

Thanks for QA Werner, indeed forgot about the case with custom fees. Will get back to this after we get release out and hopefully quash BadNonce errors

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants