Skip to content

Remove Python 2.7 FileNotFoundError compatibility shims#13985

Merged
rtibbles merged 1 commit intorelease-v0.19.xfrom
claude/remove-py27-shims-01VPXFoXyzpB4moFgnVTQXew
Jan 8, 2026
Merged

Remove Python 2.7 FileNotFoundError compatibility shims#13985
rtibbles merged 1 commit intorelease-v0.19.xfrom
claude/remove-py27-shims-01VPXFoXyzpB4moFgnVTQXew

Conversation

@rtibbles
Copy link
Copy Markdown
Member

@rtibbles rtibbles commented Dec 9, 2025

Summary

Since Python 2.7 is no longer supported, remove all instances of the FileNotFoundError compatibility shim that was used to map FileNotFoundError to IOError for Python 2.7 compatibility.

Modified files:

  • kolibri/utils/file_transfer.py
  • kolibri/utils/filesystem.py
  • kolibri/utils/server.py
  • kolibri/core/content/utils/content_manifest.py

References

Final bit of Python 2.7 compatibility code, should close #13882

Reviewer guidance

Are there any other instances of this that have been missed? Any other Python 2.7 compatibility things still extant in the codebase?

🤖 This was created by Claude Code. @rtibbles then reviewed the generated output, and did iterative rounds of updates before making it ready for review 🤖

@github-actions github-actions Bot added DEV: backend Python, databases, networking, filesystem... SIZE: small labels Dec 9, 2025
Since Python 2.7 is no longer supported, remove all instances of the
FileNotFoundError compatibility shim that was used to map FileNotFoundError
to IOError for Python 2.7 compatibility.

Modified files:
- kolibri/utils/file_transfer.py
- kolibri/utils/filesystem.py
- kolibri/utils/server.py
- kolibri/core/content/utils/content_manifest.py
@rtibbles rtibbles force-pushed the claude/remove-py27-shims-01VPXFoXyzpB4moFgnVTQXew branch from 9f06ed2 to b50fa46 Compare December 9, 2025 20:04
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 9, 2025

@rtibbles rtibbles changed the base branch from develop to release-v0.19.x December 17, 2025 20:27
@nucleogenesis nucleogenesis self-requested a review January 8, 2026 22:15
Copy link
Copy Markdown
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes here all make sense to me. The question of "are there other Python 2.7 compatibility code" seems like a question Claude'd be better equipped to answer as nothing comes to mind for me from my past experience.

Checks all pass so this should be good to merge IMO

@rtibbles rtibbles merged commit d1f6e9f into release-v0.19.x Jan 8, 2026
69 of 72 checks passed
@rtibbles rtibbles deleted the claude/remove-py27-shims-01VPXFoXyzpB4moFgnVTQXew branch January 8, 2026 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DEV: backend Python, databases, networking, filesystem... SIZE: small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Python 2.7 compatibility code from Kolibri

3 participants