fix: stop stripping issue header on unrelated label changes#90
Merged
Conversation
The `labeled`/`unlabeled` handlers fell through with an empty header whenever the changed label was not `help wanted`, then unconditionally rewrote the body — deleting the contribution header on every unrelated label add/remove. Return early for non-`help wanted` label events. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0187m8h2Mqm45A8yw5tSSfr6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The header logic was running on every label change - causing the header to be removed when unrelated labels were changed.
References
Observed on learningequality/studio #5929, #5930, #5814, #5811 (headers stripped after
good first issue/DEV: frontendwere added).Does not restore already-affected issues.
Reviewer guidance
help wantedlabeled/unlabeledevents nowreturnbeforeclearHeader/issues.update— no body write.help wantedremoval branch still reachesdeleteBotComments(moved out of the oldif).AI usage
Claude Code diagnosed the header-stripping bug and wrote the fix.