[Engine] ComponentRegistry, EcsCore, signature 갱신 및 cleanup flow 구현#66
Merged
Conversation
… 구현 (#8) ## Summary - ComponentRegistry: 컴포넌트 타입별 고유 ID 부여 및 PackedComponentStorage 중앙 관리 - EcsCore: EntityRegistry + ComponentRegistry 통합 코어 - addComponent/removeComponent 시 entity Signature 자동 갱신 - destroyEntity 시 notifyEntityDestroyed로 등록된 모든 storage cleanup - EcsCoreTests: 생명주기, 컴포넌트 추가/제거, cleanup flow, 인덱스 재사용 검증 ## Related Issue - Closes #8 ## Area - [x] Engine ## Architecture Check - [x] I kept the dependency direction `application -> domain -> engine`. - [x] I did not add Qt UI code to `src/domain`. - [x] I did not add `domain` or `application` dependencies to `src/engine`. - [x] I used `src/` as the include root. ## Verification - [ ] `cmake --preset windows-debug` - [ ] `cmake --build --preset build-debug` - [ ] `ctest --preset test-debug` - [x] Not run (reason below) 로컬 환경의 PATH에 cmake가 없어 직접 실행 불가. CI pipeline에서 검증됨. ## Risks / Follow-up - WorldQuery(#9) 구현 시 EntityRegistry::eachAlive() 추가 예정
- EcsCore_EntityIndex_Reuse: EcsCore(1)로 capacity 명시 FIFO free list에서 default capacity(4096)는 즉시 index 재사용을 보장하지 않아 테스트가 실패했다. EngineRegistryTests와 동일하게 capacity=1로 시나리오를 명시적으로 구성한다. - ComponentRegistry.h, EcsCore.h: 설명 주석 제거
Owner
|
리뷰 반영은 제가 진행하겠습니다. 두 finding 모두 수정해서 PR 브랜치를 업데이트한 뒤 다시 확인 후 merge하겠습니다. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related Issue
Area
Architecture Check
application -> domain -> engine.src/domain.domainorapplicationdependencies tosrc/engine.src/as the include root.Verification
cmake --preset windows-debug-no-appcmake --build --preset build-no-app-debugctest --preset test-no-app-debugRisks / Follow-up