[Engine] implement ComponentRegistry and EcsCore cleanup flow#59
Closed
muzygosu wants to merge 7 commits into
Closed
[Engine] implement ComponentRegistry and EcsCore cleanup flow#59muzygosu wants to merge 7 commits into
muzygosu wants to merge 7 commits into
Conversation
This reverts commit 5f0bd11.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ComponentRegistry를 추가해 컴포넌트 타입 ID와 storage를 관리합니다.EcsCore에 엔티티별Signature갱신과 명시적 cleanup flow를 추가합니다.EngineRuntime::stop()에서 ECS world를 정리하고 관련 단위 테스트를 보강합니다.Related Issue
Area
Architecture Check
application -> domain -> engine.src/domain.domainorapplicationdependencies tosrc/engine.src/as the include root.Verification
cmake --preset windows-debugcmake --build --preset build-debugctest --preset test-debugEngine/test 범위만 변경되어 빠른 검증 경로로 아래 명령을 확인했습니다.
cmake --preset windows-debug-no-appcmake --build --preset build-no-app-debugctest --preset test-no-app-debugRisks / Follow-up
EcsCore의 stale entity handle 경로는 추가 검토가 필요합니다.